CVE-2026-56831: Shopper: Negative discount values accepted and propagated through order calculation pipeline
Summary The Shopper Framework discount management functionality accepts negative discount values without server-side validation. It was confirmed that negative fixed-amount discounts can be created through the administrative interface, persisted to the database, and subsequently processed by the cart/order calculation pipeline.
Published Sep 11, 2026
Affected packages
shopper/framework
- Ecosystem
- Composer (PHP)
- Affected
- < 2.9.0
- Fixed in
- 2.9.0
- Check
composer show shopper/framework
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
The Shopper Framework discount management functionality accepts negative discount values without server-side validation.
It was confirmed that negative fixed-amount discounts can be created through the administrative interface, persisted to the database, and subsequently processed by the cart/order calculation pipeline.
The application appears to assume that discount values are always positive but does not enforce this assumption during creation, storage, or calculation.
As a result, malformed discount records can influence financial calculations and produce unintended order totals.
---
Affected Product
Package: shopper/framework
Version Tested: 2.8.1
---
Vulnerability Type
- Business Logic Vulnerability
- Improper Input Validation (CWE-20)
---
Description
While reviewing the discount functionality, it was discovered that the application accepts negative discount values through the administrative interface.
Example values tested:
-50.00
-99,999,999.00The application accepted these values without validation and stored them in the database.
Example records observed in the sh_discounts table:
1 | QCZ5Y3HESM | fixed_amount | -5000
4 | TOZKAHCB4S | fixed_amount | -9999999900This demonstrates that negative discount values are successfully persisted.
---
Steps to Reproduce
1. Create a Discount
Login as an administrator.
Navigate to:
/cpanel/discountsCreate a new discount with the following values:
Type: fixed_amount
Value: -99999999Save the discount.
2. Observe Successful Creation
The discount is accepted by the application and displayed in the administration interface.
Example:
Code: TOZKAHCB4S
Amount: -$99,999,999.003. Verify Database Persistence
Inspect the database:
select * from sh_discounts;Observed entry:
TOZKAHCB4S | fixed_amount | -9999999900---
Technical Analysis
Discount Calculation
File:
vendor/shopper/cart/src/Discounts/DiscountCalculator.phpObserved code:
$fixedAmount = $discount->value;The value is later processed without validation:
$fixedAmount = min($fixedAmount, $applicableSubtotal);When a negative value is supplied:
min(-9999999900, 10000)returns:
-9999999900allowing the negative value to continue through the calculation pipeline.
The resulting adjustment values are inserted into the database:
CartLineAdjustment::query()->insert($adjustments);No validation was identified to ensure that discount amounts are positive before calculations occur.
---
Final Total Calculation
File:
vendor/shopper/cart/src/Pipelines/Calculate.phpObserved logic:
$context->total = max(
0,
$context->taxInclusive
? $context->subtotal - $context->discountTotal
: $context->subtotal - $context->discountTotal + $context->taxTotal
);Because negative discount values are allowed to reach this stage, financial calculations are performed using malformed discount data.
Example:
Subtotal = 10000
DiscountTotal = -5000Resulting calculation:
10000 - (-5000)Result:
15000This demonstrates that negative discount values directly affect order total calculations.
---
Impact
The following was confirmed:
- Negative discount values are accepted.
- Negative discount values are persisted.
- Negative discount values are processed by the discount calculation engine.
- Negative discount values affect order total calculations.
Potential consequences include:
- Incorrect pricing calculations.
- Financial data integrity issues.
- Unexpected order totals.
- Violated assumptions within downstream pricing logic.
- Future vulnerabilities if additional components assume discount values are always positive.
Because Shopper is a headless e-commerce administration framework and does not ship with a customer-facing storefront, it was not verified a customer-facing exploitation path.
However, malformed discount records currently propagate through pricing calculations without validation.
---
Recommendation
Implement server-side validation enforcing positive discount values before persistence and before entering the calculation pipeline.
Suggested validation:
Fixed Amount Discounts
value > 0Percentage Discounts
0 < value <= 100Additionally, existing discount records should be validated before calculation to prevent malformed data from influencing pricing logic.
---
Environment
Shopper Framework 2.8.1
Laravel 12.61.1
PHP 8.4.16
SQLiteCredited to Fr6ey.
References
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More Composer (PHP) vulnerabilities
All Composer (PHP) entriesCVE-2026-56825
Shopper: Missing authorization on product removal actions in CollectionProducts component
high8.1Sep 11, 2026CVE-2026-56826
Shopping privilege escalation through missing authorization in Settings components
medium5.4Sep 11, 2026CVE-2026-56827
Shopper: Authorization bypass in Filament bulk actions allows browse-only staff to mass-delete attributes/tags and mass-toggle visibility of brands/categories/suppliers
high8.1Sep 11, 2026CVE-2026-56828
Shopper: privilege escalation via improper Livewire admin component authorization
high8.8Sep 11, 2026CVE-2026-56829
Shopper: Unauthorized inventory stock manipulation via unlocked variant property in VariantStock component
high8.1Sep 11, 2026CVE-2026-56830
Shopper: Media sub-form store() still lacks authorization (Incomplete fix for GHSA-h4mp-g9c6-xwph)
medium6.5Sep 11, 2026
