CVE-2024-29800: timber/timber vulnerable to Deserialization of Untrusted Data
Summary Timber is vulnerable to PHAR deserialization due to a lack of checking the input before passing it into the fileexists() function. If an attacker can upload files of any type to the server, he can pass in the phar:// protocol to unserialize the uploaded file and instantiate arbitrary PHP objects.
Published Apr 12, 2024 · Updated Apr 18, 2024
Affected packages
timber/timber
- Ecosystem
- Composer (PHP)
- Affected
- = 2.0.0
- Fixed in
- 2.1.0
- Check
composer show timber/timber
timber/timber
- Ecosystem
- Composer (PHP)
- Affected
- = 1.24.0
- Fixed in
- 1.24.1
- Check
composer show timber/timber
timber/timber
- Ecosystem
- Composer (PHP)
- Affected
- >= 0.16.6, < 1.23.1
- Fixed in
- 1.23.1
- Check
composer show timber/timber
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
Timber is vulnerable to PHAR deserialization due to a lack of checking the input before passing it into the file_exists() function. If an attacker can upload files of any type to the server, he can pass in the phar:// protocol to unserialize the uploaded file and instantiate arbitrary PHP objects. This can lead to remote code execution especially when Timber is used with frameworks with documented POP chains like Wordpress/ vulnerable developer code.
Details
The vulnerability lies in the run function within the toJpg.php file. The two parameters passed into it are not checked or sanitized, hence an attacker could potentially inject malicious input leading to Deserialization of Untrusted Data, allowing for remote code execution: image
PoC
Setup the following code in /var/www/html: vuln.php represents our use of Timber functions and phar-poc.php represents code with a vulnerable POP chain. image image As an attacker, we generate our PHAR payload using the following exploit script: image Generate with: image then change extension file from .phar to valid extension as svg,jpg,... image and execute vuln.php with php vuln.php, you should see whoami being executed: image image
Impact
This vulnerability is capable of remote code execution if Timber is used with frameworks or developer code with vulnerable POP chains.
Recommended Fix
Filter the phar:// protocol.
Credited to Sonicrrrr, dennisenderink.
References
- https://github.com/timber/timber/security/advisories/GHSA-6363-v5m4-fvq3
- https://github.com/timber/timber/commit/13c6b0f60346304f2eed4da1e0bb51566518de4a
- https://github.com/timber/timber/issues/2971
- https://github.com/FriendsOfPHP/security-advisories/blob/master/timber/timber/CVE-2024-29800.yaml
- https://github.com/advisories/GHSA-6363-v5m4-fvq3
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
