CVE-2024-24753: Bref Doesn't Support Multiple Value Headers in ApiGatewayFormatV2
Impacted Resources bref/src/Event/Http/HttpResponse.php:61-90 Description When Bref is used in combination with an API Gateway with the v2 format, it does not handle multiple values headers. Precisely, if PHP generates a response with two headers having the same key but different values only the latest one is kept.
Published Feb 1, 2024
Affected packages
bref/bref
- Ecosystem
- Composer (PHP)
- Affected
- < 2.1.13
- Fixed in
- 2.1.13
- Check
composer show bref/bref
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Impacted Resources
bref/src/Event/Http/HttpResponse.php:61-90
Description
When Bref is used in combination with an API Gateway with the v2 format, it does not handle multiple values headers.
Precisely, if PHP generates a response with two headers having the same key but different values only the latest one is kept.
Impact
If an application relies on multiple headers with the same key being set for security reasons, then Bref would lower the application security.
For example, if an application sets multiple Content-Security-Policy headers, then Bref would just reflect the latest one.
PoC
- Create a new Bref project.
- Create an
index.phpfile with the following content:
<?php
header("Content-Security-Policy: script-src 'none'", false);
header("Content-Security-Policy: img-src 'self'", false);
?>
<script>alert(document.domain)</script>
- Use the following
serverless.ymlto deploy the Lambda:
service: app
provider:
name: aws
region: eu-central-1
plugins:
- ./vendor/bref/bref
functions:
api:
handler: index.php
description: ''
runtime: php-81-fpm
timeout: 28 # in seconds (API Gateway has a timeout of 29 seconds)
events:
- httpApi: '*'
# Exclude files from deployment
package:
patterns:
- '!node_modules/**'
- '!tests/**'- Browse the Lambda URL.
- Notice that the JavaScript code is executed as the
Content-Security-Policy: script-src 'none'header has been removed. - Notice that the external image has not been loaded as the
Content-Security-Policy: img-src 'self'header has been kept. - Start a PHP server inside the project directory (e.g.
php -S 127.0.0.1:8090). - Browse the
index.phpscript through the PHP server (e.g. http://127.0.0.1:8090/index.php). - Notice that the JavaScript code is not executed as the
Content-Security-Policy: script-src 'none'header has been kept. - Notice that the external image has not been loaded as the
Content-Security-Policy: img-src 'self'header has been kept.
Suggested Remediation
Concatenate all the multiple value headers' values with a comma (,) as separator and return a single header with all the values to the API Gateway.
References
- https://www.rfc-editor.org/rfc/rfc9110.html#section-5.2
Credited to smaury, mnapoli.
References
- https://github.com/brefphp/bref/security/advisories/GHSA-99f9-gv72-fw9r
- https://nvd.nist.gov/vuln/detail/CVE-2024-24753
- https://github.com/brefphp/bref/commit/f834027aaf88b3885f4aa8edf6944ae920daf2dc
- https://github.com/brefphp/bref/blob/2.1.12/src/Event/Http/HttpResponse.php#L61-L90
- https://github.com/advisories/GHSA-99f9-gv72-fw9r
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More Composer (PHP) vulnerabilities
All Composer (PHP) entriesCVE-2024-29186
Slow String Operations via MultiPart Requests in Event-Driven Functions
medium5.3Mar 22, 2024CVE-2024-24752
Bref's Uploaded Files Not Deleted in Event-Driven Functions
medium6.5Feb 1, 2024CVE-2024-24754
Bref vulnerable to Body Parsing Inconsistency in Event-Driven Functions
low3.7Feb 1, 2024
